Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: print valid flag values in error message when using exactlyOne #349

Merged
merged 3 commits into from
Feb 25, 2022
Merged

fix: print valid flag values in error message when using exactlyOne #349

merged 3 commits into from
Feb 25, 2022

Conversation

cristiand391
Copy link
Member

@cristiand391 cristiand391 commented Jan 24, 2022 •
edited
Loading

When a flag uses the exactlyOne flag property in one command and then you run the command without passing any flag you get a wrong error message.

ERROR running command:test:  Exactly one of the following must be provided: m,a,n,i,f,e,s,t

With this fix:

ERROR running command:test:  Exactly one of the following must be provided: --manifest, --metadata, --sourcepath, --validateddeployrequestid

@salesforce-cla
Copy link

Thanks for the contribution! It looks like @cristiand391 is an internal user so signing the CLA is not required. However, we need to confirm this.

@cristiand391 cristiand391 mentioned this pull request Jan 24, 2022
Closed
@salesforce-cla
Copy link

Thanks for the contribution! It looks like @cristiand391 is an internal user so signing the CLA is not required. However, we need to confirm this.

@mdonnalley mdonnalley merged commit ddcaeb2 into oclif:main Feb 25, 2022
@cristiand391 cristiand391 deleted the cd/fix-exactly-one-error branch February 25, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdonnalley mdonnalley mdonnalley approved these changes

Assignees
No one assigned
Labels
cla:missing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristiand391 @mdonnalley